BIP 0016 QA: Difference between revisions

From Bitcoin Wiki
Jump to navigation Jump to search
Gavinandresen (talk | contribs)
No edit summary
Luke-jr (talk | contribs)
No edit summary
Line 1: Line 1:
This page is a Quality Assurance test plan for BIP 16.  If you see a test missing, please add it.
This page is a Quality Assurance test plan for BIPs 17.  If you see a test missing, please add it.
If you can help test, please edit this page to sign-off on it.
If you can help test, please edit this page to sign-off on it.


{| class="wikitable"
{| class="wikitable"
|-
|-
! Done !! Test Procedure !! Tested by
! Testnet !! Mainnet !! Test Procedure !! Tested by


|- style="color:green;"
|- style="color:red;"
| ✓
| ||
| Run BIP-16-capable Bitcoin 0.6 on testnet and main net<br />
| Run BIP-17-capable Bitcoin 0.6 on testnet and main net<br />
Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands<br />
Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands<br />
Result: coins sent in all cases
Result: coins sent in all cases
| Gavin Andresen
|  


|- style="color:green;"
|- style="color:lime;"
| &#x2713;
| &#x2713; || &#x2713;
| Test multisig 1-of-1<br />
| Test multisig 1-of-1<br />
Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)<br />
Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)<br />
Line 21: Line 21:
Result: transaction is confirmed by network, displays properly in listtransactions.
Result: transaction is confirmed by network, displays properly in listtransactions.
Result: balance is unaffected
Result: balance is unaffected
| Gavin Andresen
| Luke Dashjr


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Test multisig 1-of-2<br />
| Test multisig 1-of-2<br />
Run 0.6 bitcoind, get 2 new bitcoin addresses<br />
Run 0.6 bitcoind, get 2 new bitcoin addresses<br />
Line 31: Line 31:
Result: transaction is confirmed by network, displays properly in listtransactions.
Result: transaction is confirmed by network, displays properly in listtransactions.
Result: bitcoin balance is unaffected.
Result: bitcoin balance is unaffected.
| Gavin Andresen
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Test multisig 1-of-3, 2-of-3, 3-of-3<br />
| Test multisig 1-of-3, 2-of-3, 3-of-3<br />
Repeat test procedures above, with the other new multisignature transaction types
Repeat test procedures above, with the other new multisignature transaction types
| Gavin Andresen
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Test multisig send-to-other<br />
| Test multisig send-to-other<br />
Repeat test procedures above, but use two bitcoinds, prepared as follows:<br />
Repeat test procedures above, but use two bitcoinds, prepared as follows:<br />
Line 49: Line 49:
Result: balance for 2 goes down, listtransactions for 2 displays correct result<br />
Result: balance for 2 goes down, listtransactions for 2 displays correct result<br />
Result: balance for 1 goes up, listtransactions for 1 displays correct result<br />
Result: balance for 1 goes up, listtransactions for 1 displays correct result<br />
| Gavin Andresen
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Test redeeming multisignature transactions<br />
| Test redeeming multisignature transactions<br />
Fund a new, empty wallet entirely with multisig transactions<br />
Fund a new, empty wallet entirely with multisig transactions<br />
Line 60: Line 60:
Result: transactions are accepted/confirmed by network<br />
Result: transactions are accepted/confirmed by network<br />
Result: balance decreases, listtransactions displays correct information<br />
Result: balance decreases, listtransactions displays correct information<br />
| Gavin Andresen
|  


|- style="color:red;"
|- style="color:red;"
|
| ||
| Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above<br />
| Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above<br />
Result: balance and transactions displayed correctly
Result: balance and transactions displayed correctly
|
|


|- style="color:orange;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP-16-capable backport Bitcoin 0.3.19 through 0.5.1 on testnet and main net<br />
| Run BIP-17-capable backport Bitcoin 0.3.19 through 0.5.1<br />
Send coins using GUI, RCP sendtoaddress, and RCP sendmany commands<br />
Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands<br />
Result: coins sent in all cases
Result: coins sent in all cases
| Gavin Andresen (tested 0.3.19, 0.3.24 and 0.5.1)
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| || n/a
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
| Run BIP-17-capable Bitcoin 0.6.0<br />
Mine coins using built-in miner<br />
Mine coins using built-in miner<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| &#x2713; ||
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
| Run BIP-17-capable Bitcoin 0.6.0<br />
Mine coins using getwork interface<br />
Mine coins using getwork interface<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen
|  


|- style="color:red;"
|- style="color:red;"
|
| ||
| Run BIP-16-capable Bitcoin 0.6.0 on testnet<br />
| Run BIP-17-capable Bitcoin 0.6.0<br />
Mine coins using getmemorypool interface<br />
Mine coins using getmemorypool interface<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
|  
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
| Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports<br />
Mine coins using built-in miner<br />
Mine coins using built-in miner<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen (tested all on a testnet-in-a-box)
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
Mine coins using getwork interface<br />
Mine coins using getwork interface<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen (tested all on a testnet-in-a-box)
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP-16-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
| Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet<br />
Mine coins using built-in miner<br />
Mine coins using built-in miner<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen (tested all on a testnet-in-a-box)
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
Mine coins using getwork interface<br />
Mine coins using getwork interface<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
| Gavin Andresen (tested all on a testnet-in-a-box)
|  
|- style="color:red;"


|- style="color:red;"
|- style="color:red;"
|
| ||
| Run BIP-16-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
| Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet<br />
Mine coins using getmemorypool interface<br />
Mine coins using getmemorypool interface<br />
Result: blocks accepted, show up on blockexplorer.com/testnet<br />
Result: blocks accepted, show up on pre-BIP17 clients<br />
Result: mined blocks' coinbase contains /P2SH/ string
Result: mined blocks' coinbase contains p2sh/CHV string
|  
|  


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Create/run unit tests for:<br />
| Create/run unit tests for:<br />
multisignature signing/verification<br />
multisignature signing/verification<br />
Line 147: Line 146:
multisignature IsStandard() success/failure<br />
multisignature IsStandard() success/failure<br />
extraction of addresses from multisignature transactions<br />
extraction of addresses from multisignature transactions<br />
BIP 16 IsStandard() success/failure (including failure with OP_PUSHDATA1/2/4)<br />
BIP 17 IsStandard() success/failure<br />
BIP 16 AreInputsStandard() success/failure<br />
BIP 17 AreInputsStandard() success/failure<br />
BIP 16 compatibility with other 3 standard transaction types<br />
BIP 17 compatibility with other 3 standard transaction types<br />
BIP 16 no-recursion test<br />
BIP 17 switchover date logic<br />
BIP 16 switchover date logic<br />
|  
OP_CHECKMULTISIG counting of signature operations inside BIP 16 transactions<br />
| Gavin Andresen (see test/multisig_tests.cpp, test/script_tests.cpp, test/script_P2SH_tests.cpp, test/sigopcount_tests.cpp in the bitcoin source tree; 'make test_bitcoin' in src/ directory to compile)


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Create/run 'transaction fuzzer' to stress-test BIP 16 transactions
| Create/run 'transaction fuzzer' to stress-test BIP 17 transactions
| Gavin Andresen (https://github.com/gavinandresen/bitcoin-git/tree/fuzzer , run twice on both testnet-in-a-box and testnet with 100,000 'fuzzed' transactions each test run)
|  


|- style="color:red;"
|- style="color:red;"
|
| ||
| Run Bitcoin 0.6 on main net <br />
| Run Bitcoin 0.6 on main net <br />
Result: blocks created properly
Result: blocks created properly
Result: blocks include /P2SH/ string in their coinbase
Result: blocks include p2sh/CHV string in their coinbase
|
|


|- style="color:green;"
|- style="color:red;"
| &#x2713;
| ||
| Run BIP 16 vinced_mergedmine backport on main net <br />
| Run BIP 17 vinced_mergedmine backport on main net <br />
Result: blocks created properly
Result: blocks created properly
Result: blocks include /P2SH/ string in their coinbase
Result: blocks include p2sh/CHV string in their coinbase
| (Gavin for slush: after bug fixes, running with no issues)<br />
|  


|}
|}

Revision as of 17:47, 30 January 2012

This page is a Quality Assurance test plan for BIPs 17. If you see a test missing, please add it. If you can help test, please edit this page to sign-off on it.

Testnet Mainnet Test Procedure Tested by
Run BIP-17-capable Bitcoin 0.6 on testnet and main net

Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands
Result: coins sent in all cases

Test multisig 1-of-1

Run 0.6 bitcoind, get a public key with: ./bitcoind -testnet validateaddress $(./bitcoind -testnet getnewaddress)
Generate a multisig 1-of-1 address: ./bitcoind addmultisigaddress 1 {public key from above}
Send-to-self some bitcoins using that address
Result: transaction is confirmed by network, displays properly in listtransactions. Result: balance is unaffected

Luke Dashjr
Test multisig 1-of-2

Run 0.6 bitcoind, get 2 new bitcoin addresses
Generate a multisig 1-of-2 address: ./bitcoind addmultisigaddress 1 {address1} {address2}
Send-to-self some bitcoins using that address
Result: transaction is confirmed by network, displays properly in listtransactions. Result: bitcoin balance is unaffected.

Test multisig 1-of-3, 2-of-3, 3-of-3

Repeat test procedures above, with the other new multisignature transaction types

Test multisig send-to-other

Repeat test procedures above, but use two bitcoinds, prepared as follows:
bitcoind 1 : Run getnewaddress and addmultisigaddress
bitcoind 2 : Just addmultisigaddress
Send coins from 2 to 1 using the address
Result: transaction is accepted/confirmed by network
Result: balance for 2 goes down, listtransactions for 2 displays correct result
Result: balance for 1 goes up, listtransactions for 1 displays correct result

Test redeeming multisignature transactions

Fund a new, empty wallet entirely with multisig transactions
Wait for transactions to confirm
Use sendtoaddress and sendmany to generate spend-from-multisig transactions
Spend to both single-address and multisig address, and test send-to-other and send-to-self
Result: transactions are accepted/confirmed by network
Result: balance decreases, listtransactions displays correct information

Run 0.6 Bitcoin-Qt GUI on one of the test wallets from above

Result: balance and transactions displayed correctly

Run BIP-17-capable backport Bitcoin 0.3.19 through 0.5.1

Send coins using GUI, RPC sendtoaddress, and RPC sendmany commands
Result: coins sent in all cases

n/a Run BIP-17-capable Bitcoin 0.6.0

Mine coins using built-in miner
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 0.6.0

Mine coins using getwork interface
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 0.6.0

Mine coins using getmemorypool interface
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports

Mine coins using built-in miner
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getwork interface
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 0.3.19 through 0.5.1 backports on testnet

Mine coins using built-in miner
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getwork interface
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Run BIP-17-capable Bitcoin 3.19 through 0.5.1 backports on testnet

Mine coins using getmemorypool interface
Result: blocks accepted, show up on pre-BIP17 clients
Result: mined blocks' coinbase contains p2sh/CHV string

Create/run unit tests for:

multisignature signing/verification
multisignature invalid signature failure
multisignature IsStandard() success/failure
extraction of addresses from multisignature transactions
BIP 17 IsStandard() success/failure
BIP 17 AreInputsStandard() success/failure
BIP 17 compatibility with other 3 standard transaction types
BIP 17 switchover date logic

Create/run 'transaction fuzzer' to stress-test BIP 17 transactions
Run Bitcoin 0.6 on main net

Result: blocks created properly Result: blocks include p2sh/CHV string in their coinbase

Run BIP 17 vinced_mergedmine backport on main net

Result: blocks created properly Result: blocks include p2sh/CHV string in their coinbase